Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't notarize mas builds #7838

Merged
merged 3 commits into from
Oct 25, 2023
Merged

fix: Don't notarize mas builds #7838

merged 3 commits into from
Oct 25, 2023

Conversation

mifi
Copy link
Contributor

@mifi mifi commented Oct 20, 2023

I just switched from electron-builder-notarize to the new built in notarize system. electron-builder-notarize will check and not notarize mas builds: https://github.com/karaggeorge/electron-builder-notarize/blob/efb683af5f4c5428ea6aa02df6a09a360563bfa0/index.js#L49 however https://github.com/electron/notarize does not seem to do that. This causes the notarization to fail because Mac App Store signed mas builds cannot be notarized:

Processing: /Users/runner/work/lossless-cut/lossless-cut/dist/mas-universal/LosslessCut.app
...
CloudKit query for LosslessCut.app (2/830f452ef727fad7dc1ae62586bf2442bff5fcb5) failed due to "Record not found".
Could not find base64 encoded ticket in response for 2/830f452ef727fad7dc1ae62586bf2442bff5fcb5
The staple and validate action failed! Error 65.

see build https://github.com/mifi/lossless-cut/actions/runs/6572171949/job/17852779360

however after this fix it works:

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 1b57306

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Oct 20, 2023 •
edited
Loading

✅ Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 1b57306
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/653921baf2716d00089d75c0
😎 Deploy Preview https://deploy-preview-7838--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mifi mifi changed the title Don't notarize mas builds fix: Don't notarize mas builds Oct 20, 2023
@CharlesBT CharlesBT mentioned this pull request Oct 25, 2023
Open
3 tasks
@mmaietta mmaietta merged commit 87eae1c into electron-userland:master Oct 25, 2023
11 checks passed
This was referenced Oct 25, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaietta mmaietta mmaietta left review comments

Assignees
No one assigned
Labels
app-builder-lib mac
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mifi @mmaietta